Simplify Client.Do function and lock usage#2038
Merged
erikdubbelboer merged 2 commits intovalyala:masterfrom Jul 19, 2025
Merged
Simplify Client.Do function and lock usage#2038erikdubbelboer merged 2 commits intovalyala:masterfrom
erikdubbelboer merged 2 commits intovalyala:masterfrom
Conversation
1. Simplify the Client.Do function, extract the acquisition of HostClient object into a separate function, and simplify the lock code 2. Remove redundant code from the AcquireReader and AcquireWriter functions of HostClient
Contributor
Author
|
@erikdubbelboer Please help me rerun the test. There is no problem running it in my fork branch. I don't know why there is a problem running the test here. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the request handling in Client.Do by extracting host lookup and creation into a dedicated helper and streamlines lock usage. It also removes duplicate buffer-initialization branches in HostClient’s reader and writer acquisition methods.
- Extracts
hostClienthelper to centralize map access and locking - Moves
pendingClientRequestsatomic increments into the top-levelDomethod - Simplifies
AcquireWriterandAcquireReaderby consolidatingnil-check branches
Comments suppressed due to low confidence (1)
client.go:526
- [nitpick] The helper
hostClientretrieves or initializes aHostClient. Renaming it togetHostClient(or similar) could make its intent clearer and align with common getter naming conventions.
func (c *Client) hostClient(host []byte, isTLS bool) (*HostClient, error) {
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.