nsuser: replace deprecated NSUserNotification with osascript display notification#168
Open
munyari wants to merge 1 commit intovariadico:mainfrom
Open
nsuser: replace deprecated NSUserNotification with osascript display notification#168munyari wants to merge 1 commit intovariadico:mainfrom
munyari wants to merge 1 commit intovariadico:mainfrom
Conversation
munyari
changed the title
munyari
changed the title
…notification Apple removed NSUserNotification in macOS 13 (Ventura). Since then, noti's macOS banner notifications have been silently failing. This change replaces the Objective-C CGO implementation with a pure Go implementation that shells out to `osascript -e 'display notification ...'`. This is the same mechanism the user would invoke manually from the terminal and works on all current macOS versions. The old implementation used method swizzling to override `NSBundle.bundleIdentifier` (spoofing `com.apple.terminal`) and ran an `NSRunLoop` to wait for delivery confirmation. None of that machinery is needed with osascript, which handles delivery. Changes: - Remove nsuser_darwin.h (Objective-C CGO bridge) - Rewrite nsuser_darwin.go as pure Go using os/exec - Escape backslashes, double quotes, and control characters (newlines, tabs, carriage returns) in AppleScript strings to prevent injection and syntax errors - Log a warning when `ContentImage` is set, since display notification does not support custom images (feature regression, but `NSUserNotification`'s image support was apparently broken on recent macOS) - Remove the darwin-specific Makefile release target; the wildcard rule with `CGO_ENABLED=0` now covers darwin since CGO is no longer needed - Add unit tests for `escapeAS` and `buildScript`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple removed NSUserNotification in macOS 13 (Ventura). Since then, noti's macOS banner notifications have been silently failing.
This change replaces the Objective-C CGO implementation with a pure Go implementation that shells out to
osascript -e 'display notification ...'. This is the same mechanism the user would invoke manually from the terminal and works on all current macOS versions.The old implementation used method swizzling to override
NSBundle.bundleIdentifier(spoofingcom.apple.terminal) and ran anNSRunLoopto wait for delivery confirmation. None of that machinery is needed with osascript, which handles delivery.Changes:
ContentImageis set, since display notification does not support custom images (feature regression, butNSUserNotification's image support was apparently broken on recent macOS)CGO_ENABLED=0now covers darwin since CGO is no longer neededescapeASandbuildScript