fix: when the form is opened repeatedly, the state is unexpectedly stroyed

[anncwb]

Description

fixed #4394

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features

  • Introduced a form submission function that displays submitted values as a JSON string, enhancing user feedback and interactivity.

• Bug Fixes

  • Adjusted state management in the form API during the unmounting process, potentially improving lifecycle management.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0426fdd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes involve modifications to the FormApi class's unmounted method, where a line resetting the state to null has been commented out, potentially altering state management during component unmounting. Additionally, a new onSubmit function has been introduced in the form-model-demo.vue file to handle form submissions, providing user feedback by displaying submitted values.

Changes

Files	Change Summary
packages/@core/ui-kit/form-ui/src/form-api.ts	Commented out the line that sets this.state to null in the unmounted method of FormApi.
playground/src/views/examples/modal/form-model-demo.vue	Added a new onSubmit function to handle form submissions and display submitted values as JSON.

Assessment against linked issues

Objective	Addressed	Explanation
Handle form submission in modal after reopening (Issue #4394)	✅
Ensure form's handleSubmit is correctly set upon modal open (Issue #4394)	❌	The change does not reset the handleSubmit function on reopening.

🐰 In the meadow, forms do bloom,
With each submission, dispelling gloom.
Values displayed, a JSON delight,
Changes in code make everything right!
Hopping along, we celebrate today,
For forms and modals, come out to play! 🌼

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c3d0102 and 0426fdd.

Files selected for processing (2)

• packages/@core/ui-kit/form-ui/src/form-api.ts (1 hunks)
• playground/src/views/examples/modal/form-model-demo.vue (1 hunks)

Additional comments not posted (3)

playground/src/views/examples/modal/form-model-demo.vue (3)

4-4: LGTM!

The import statement for the message module from the ant-design-vue library is correctly written. This module is likely used to display user feedback messages in the form.

---

12-14: LGTM!

The onSubmit function is correctly defined and typed. It provides user feedback by displaying the submitted form values as a JSON string using the message.info method, which is a good practice. This function is likely used as a callback for the form's handleSubmit event.

---

17-17: Verify if the issue is resolved.

The assignment of the onSubmit function to the handleSubmit property of the useVbenForm hook configuration is correctly written. This change integrates the onSubmit function into the form's submission logic.

Based on the PR objectives, this change is part of the fix for the issue where the form's submission logic was not being triggered correctly when the modal was opened multiple times.

Please verify if this change, along with the other changes in the PR, resolves the issue described in #4394. Test the modal and form interaction by opening and closing the modal multiple times and submitting the form to ensure that the onSubmit function is called correctly each time.