fix: form label and control style #5580
Conversation
|
|
Warning Rate limit exceeded@mynetfan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 5 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
WalkthroughThis pull request updates the form rendering components by enhancing the Changes
Sequence Diagram(s)sequenceDiagram
participant Parent
participant FormField
participant FormLabel
Parent->>FormField: Pass props (including label and colon)
FormField->>FormLabel: Render with provided props
alt Label is provided
FormLabel->>FormLabel: Render label text
alt Colon is true
FormLabel->>FormLabel: Append colon to label
end
else Label not provided
FormLabel->>FormLabel: Skip label rendering
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/@core/ui-kit/form-ui/src/form-render/form-field.vue (1)
315-315: Consider standardizing padding values.The
p-[2px]padding seems arbitrary. Consider using design system spacing tokens for consistency.- <div class="flex-auto overflow-hidden p-[2px]"> + <div class="flex-auto overflow-hidden p-0.5">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/@core/ui-kit/form-ui/src/form-render/form-field.vue(1 hunks)packages/@core/ui-kit/form-ui/src/form-render/form-label.vue(2 hunks)playground/src/views/examples/form/basic.vue(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Test (windows-latest)
- GitHub Check: Lint (windows-latest)
- GitHub Check: Check (windows-latest)
- GitHub Check: post-update (windows-latest)
- GitHub Check: post-update (ubuntu-latest)
- GitHub Check: Lint (ubuntu-latest)
- GitHub Check: Check (ubuntu-latest)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (5)
packages/@core/ui-kit/form-ui/src/form-render/form-label.vue (2)
13-13: LGTM! Props added to enhance label customization.The new props
colonandlabelprovide better control over label rendering and formatting.Also applies to: 15-15
24-24: LGTM! Improved conditional rendering logic.The template changes ensure:
- Required asterisk (*) only shows when both
requiredandlabelare present- Colon (:) only appears when both
colonandlabelare present- Consistent spacing with
mr-[2px]andml-[2px]classesAlso applies to: 29-29
packages/@core/ui-kit/form-ui/src/form-render/form-field.vue (1)
304-305: LGTM! FormLabel integration complete.The FormLabel component is properly configured with the new
:colonand:labelprops.playground/src/views/examples/form/basic.vue (2)
238-241: LGTM! Improved type safety with boolean validation.The change from
z.any()toz.boolean()provides better type safety and validation for the checkbox field.
271-272: LGTM! Enhanced help text clarity.The help text now provides more detailed guidance with three lines of information.
mynetfan
force-pushed
the
fix/form-style
branch
from
c9a8ac8 to
d359300
Compare
1 participant
Description
调整表单样式：help移到冒号之前，组件添加适当间距
Type of change
Please delete options that are not relevant.
pnpm-lock.yamlunless you introduce a new test example.Checklist
pnpm run docs:devcommand.pnpm test.feat:,fix:,perf:,docs:, orchore:.Summary by CodeRabbit
New Features
Style