Skip to content

perf: page componet supports custom height offset for flexible content height … #6081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jinmao88 merged 3 commits into from
Apr 29, 2025
Merged

perf: page componet supports custom height offset for flexible content height … #6081

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d99038f
perf: Page supports custom height offset for flexible content height …
jinmao88 Apr 29, 2025
fce444d
chore: typo
jinmao88 Apr 29, 2025
142611e
perf(page): replace height with heightOffset for flexible content sizing
jinmao88 Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/effects/common-ui/src/components/page/page.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ defineOptions({
name: 'Page',
});

const { autoContentHeight = false } = defineProps<PageProps>();
const { autoContentHeight = false, height = 0 } = defineProps<PageProps>();

const headerHeight = ref(0);
const footerHeight = ref(0);
Expand All @@ -24,7 +24,7 @@ const footerRef = useTemplateRef<HTMLDivElement>('footerRef');
const contentStyle = computed<StyleValue>(() => {
if (autoContentHeight) {
return {
height: `calc(var(${CSS_VARIABLE_LAYOUT_CONTENT_HEIGHT}) - ${headerHeight.value}px)`,
height: `calc(var(${CSS_VARIABLE_LAYOUT_CONTENT_HEIGHT}) - ${headerHeight.value}px - ${height}px)`,
overflowY: shouldAutoHeight.value ? 'auto' : 'unset',
};
}
Expand Down
1 change: 1 addition & 0 deletions packages/effects/common-ui/src/components/page/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ export interface PageProps {
autoContentHeight?: boolean;
headerClass?: string;
footerClass?: string;
height?: number | string;
}
Loading