fix: fix vxeTable commit proxy

[jinmao88]

Description

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• Refactor
  • Simplified the refresh configuration in grid toolbars to use a boolean flag instead of an object in several system views.
  • Updated grid initialization to use a different action code for data loading.

[changeset-bot]

⚠️ No Changeset found

Latest commit: f08ea8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes update the initialization behavior of a grid component by altering the argument passed to its proxy commit method from 'initial' to 'query'. Additionally, several grid toolbar configurations are simplified by changing the refresh property from an object with a code to a boolean flag.

Changes

Files	Change Summary
packages/effects/plugins/src/vxe-table/use-vxe-grid.vue	Changed commitProxy initialization argument from 'initial' to 'query'.
playground/src/views/system/dept/list.vue	Changed grid toolbar refresh property from { code: 'query' } to true.
playground/src/views/system/menu/list.vue, playground/src/views/system/role/list.vue	Changed grid toolbar refresh property from { code: 'query' } to true. (same as above)

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GridComponent
    participant ProxyAPI

    User->>GridComponent: Initialize
    GridComponent->>ProxyAPI: commitProxy('query', formValues)
    ProxyAPI-->>GridComponent: Data response
    GridComponent-->>User: Render data in grid

Loading

Possibly related PRs

• chore: update-vxe-table #6516: Updates the argument for commitProxy from '_init' to 'initial', indicating sequential changes to the same method call as this PR.

Suggested reviewers

• anncwb
• vince292007

Poem

A hop, a skip, a code refresh,
The grid now queries, clean and fresh.
Toolbars simplified, less to see,
Boolean flags bring clarity.
With every change, the data flows,
As rabbits cheer where carrots grow! 🥕

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 07b64ad and f08ea8f.

📒 Files selected for processing (4)

• packages/effects/plugins/src/vxe-table/use-vxe-grid.vue (1 hunks)
• playground/src/views/system/dept/list.vue (1 hunks)
• playground/src/views/system/menu/list.vue (1 hunks)
• playground/src/views/system/role/list.vue (1 hunks)

🧰 Additional context used

🧠 Learnings (3)

playground/src/views/system/menu/list.vue (1)

Learnt from: mynetfan
PR: vbenjs/vue-vben-admin#5397
File: playground/src/bootstrap.ts:23-30
Timestamp: 2025-01-15T04:29:13.944Z
Learning: In the Vue-Vben-Admin project, commented code in bootstrap.ts showing modal and drawer configuration examples should be preserved as reference documentation, even after moving to CSS variables for z-index management.

playground/src/views/system/role/list.vue (1)

Learnt from: mynetfan
PR: vbenjs/vue-vben-admin#5397
File: playground/src/bootstrap.ts:23-30
Timestamp: 2025-01-15T04:29:13.944Z
Learning: In the Vue-Vben-Admin project, commented code in bootstrap.ts showing modal and drawer configuration examples should be preserved as reference documentation, even after moving to CSS variables for z-index management.

playground/src/views/system/dept/list.vue (1)

Learnt from: mynetfan
PR: vbenjs/vue-vben-admin#5397
File: playground/src/bootstrap.ts:23-30
Timestamp: 2025-01-15T04:29:13.944Z
Learning: In the Vue-Vben-Admin project, commented code in bootstrap.ts showing modal and drawer configuration examples should be preserved as reference documentation, even after moving to CSS variables for z-index management.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Check (ubuntu-latest)
• GitHub Check: Check (windows-latest)
• GitHub Check: Test (windows-latest)
• GitHub Check: Lint (ubuntu-latest)
• GitHub Check: Lint (windows-latest)
• GitHub Check: post-update (ubuntu-latest)
• GitHub Check: post-update (windows-latest)

🔇 Additional comments (4)

playground/src/views/system/role/list.vue (1)

55-55: LGTM - Consistent toolbar configuration simplification.

This change aligns with the core proxy commit fix, simplifying the refresh configuration from { code: 'query' } to true while maintaining the same underlying functionality.

playground/src/views/system/menu/list.vue (1)

47-47: LGTM - Consistent toolbar configuration simplification.

This change aligns with the core proxy commit fix, simplifying the refresh configuration from { code: 'query' } to true while maintaining the same underlying functionality.

playground/src/views/system/dept/list.vue (1)

113-113: LGTM - Consistent toolbar configuration simplification.

This change aligns with the core proxy commit fix, simplifying the refresh configuration from { code: 'query' } to true while maintaining the same underlying functionality.

packages/effects/plugins/src/vxe-table/use-vxe-grid.vue (1)

303-303: LGTM - Core fix standardizes proxy commit behavior.

Changing the commitProxy argument from 'initial' to 'query' standardizes the grid initialization behavior to use the same action as refresh operations. This aligns with the toolbar configuration simplifications in the playground files and ensures consistent proxy behavior across the system.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[yfmei]

@jinmao88 为什么 intitial 要改成 query？intitial 会重置到第一页，清空勾选状态。原来只是参数名变更，现在是逻辑变更了，有什么特殊原因吗？