Conversation
mattijn
left a comment
There was a problem hiding this comment.
Thanks! If you have more insight where to place empty=False, that would be great. I thought we could control everything within the alt.selection_point(), but that seems not to be the case.
I added two suggestions that shows on a single line the when().then()'s
|
From a programming perspective I can understand that you just want to |
@mattijn all good with me, I'll accept the suggestions and we can get this merged |
Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
|
#3487 will fix the unrelated |
|
Thanks! Tests pass now🥳 |
This was already being handled internally, but now aligns with `when` and provides a documentable parameter. Related: vega#3485 (comment)
Fixes #3301
Utilises
alt.when, introduced in #3427@mattijn I thought adding this first would be something to refer to in the follow-up PR discussed in #3427 (comment)
Also revisiting since #2759 (comment) I have a better explanation for the
empty=Falseplacement.For
select, theParameteris used twice - once withempty=Falseand another with the default.Whereas
highlightis used only once.I think this could be helpful to add to the
alt.condition(empty)and each.when(empty)doc, as this is a good justification for why you can passemptythere.https://github.com/dangotbanned/altair/blob/ef81573b9c709989d3965f778a5b0c5d77f6d4c3/tests/examples_methods_syntax/interactive_bar_select_highlight.py#L26-L45