ci: Switch from hatch, pip to uv in GitHub Actions#3719
ci: Switch from hatch, pip to uv in GitHub Actions#3719dangotbanned merged 16 commits intovega:mainfrom
hatch, pip to uv in GitHub Actions#3719Conversation
Replaced the `hatch` scripts with the actual commands
Was incompatible with `altair-plot` https://github.com/dangotbanned/altair/actions/runs/12438573015/job/34730739535
| on: [push, pull_request] | ||
|
|
||
| env: | ||
| UV_SYSTEM_PYTHON: 1 |
There was a problem hiding this comment.
Great PR @dangotbanned! Do you have a reference why this is environment definition is necessary? Thanks!
There was a problem hiding this comment.
Thanks @mattijn!
Yeah I can explain.
I've enabled UV_SYSTEM_PYTHON as a workflow environment variable to add the --system argument on all relevant uv commands.
You can see in narwhals/.github/workflows/downstream_tests.yml that argument is used 25 times.
So this is just to keep it simple, making sure it is there when needed - but isn't something you need to worry about if updating the workflow in the future 🙂
|
Regarding feedback on parallel running of sphinx docs: Is this something worthwhile pursuing for? |
It has the potential to speed this CI job up, but I think I'd struggle with testing
I'm happy to support if anyone else wants to take the lead on it though. I really need to transition away from windows at some point 😔 |
|
Thanks for providing context regarding the environment variable of In fact I'm quite happy that we have maintainers on multiple operating systems as it increase the robustness of the codebase. |
Closes #3718
One step towards #3577
This PR moves to
uvin each of:build.ymldocbuild.ymllint.ymlI tried this a while back, but gave up on (27999c1).
Since then, I've used
uvsome more as I mentioned in (#3577 (comment)) - which helped unblock this part 😅