Conversation
914dcca to
4dc801d
Compare
|
Hey @mattijn, CI is failing on the "minimum required deps" checks: # install latest versions of all packages
uv pip install -e ".[dev, all]"
# force some packages to specific versions
uv pip install jsonschema==3.0 narwhals==1.27.1 typing_extensions==4.12.0
# activate venv and run python directly
# note: using "uv run" will reset the dependencies to those in uv.lock
source .venv/bin/activate
python3 tools/generate_schema_wrapper.pyWith the following error: File "...3.14.3/x64/lib/python3.14/site-packages/jsonschema/__init__.py", line 32, in <module>
from pkg_resources import get_distribution
ModuleNotFoundError: No module named 'pkg_resources'I see no errors in my local testing when I run: # install package versions from uv.lock
uv sync --all-extras
uv run task generate_schema_wrapperThe CI issue seems unrelated to the |
|
Thanks @alec-bike for your PR! In #3950 I've resolved serveral issues in CI. I hesitate a bit to merge that one, since these should in fact be multiple different PRs, but CI will only pass if all changes are merged.. |
|
I found the issue -- latest The CI minimum dependency check now runs: uv pip install -e ".[dev, all]"
uv pip install jsonschema==3.0 narwhals==1.27.1 typing_extensions==4.12.0 setuptools==81.0.0Which passes, but the PR now fails on pytest for python 3.14 minimum deps: FAILED tests/vegalite/v6/test_api.py::test_chart_infer_types -
ValueError: Invalid frequency: Y. Failed to parse with error message:
ValueError("'Y' is no longer supported for offsets. Please use 'YE' instead.") |
|
Nice! I have adapted the description and title of #3950 so it can be merged. Can you please rebase so we can check if the CI will pass in this PR as well again. |
c6b51c9 to
dfdc028
Compare
|
That did the trick. The PR now passes CI, thanks! |
|
Great! Once you think we need or are ready to adopt basedpyright or ty within CI, you may do so👍 |
|
@mattijn I think this PR is ready for review. These changes reduce errors for ty and basedpyright by addressing code issues (rather than adding exceptions). I also simplified some annotations to make them not specific to mypy. For now, sticking with |
|
Should the minimum python version be updated to 3.10 in Edit: I tried this locally and it throws a lot of ruff errors for deprecated code. Looks like a separate PR would be needed. |
0821cf7 to
402cdb7
Compare
402cdb7 to
a812b45
Compare
a812b45 to
09c0f42
Compare
|
Thanks again for this PR! Just to make sure I understand it correctly, our minimum-dependencies CI job pins Edit: yups, that's the case👍 |
This PR reduces the number of type errors in
altair/vegalite/v6/api.pywhen using basedpyright or ty for type checking.