chore!: Rename weather.json -> weekly-weather.json#650
Conversation
domoritz
left a comment
There was a problem hiding this comment.
Should we make a release before merging this or include it in the next major release?
|
Thanks for approving @domoritz
No strong feelings from me. EditMaybe time the major release here to be before |
|
Yep, I was just wondering whether there is anything we want to release before a major release. |
Once this and #648 are merged, we'll have no more open issues. The only thing I've been considering was standardising date/time format strings. This isn't every case, but demonstrates some formats Integer yearvega-datasets/data/barley.json Line 1 in a88ff4c vega-datasets/data/disasters.csv Line 2 in a88ff4c vega-datasets/data/driving.json Line 3 in a88ff4c Line 5 in a88ff4c vega-datasets/data/monarchs.json Line 2 in a88ff4c Float time
{"delay":-11,"distance":2419,"time":0.016666666666666666}String date/datetimeLine 10 in a88ff4c
"date":"2001/01/01 06:55",Line 2 in a88ff4c vega-datasets/data/la-riots.csv Line 2 in a88ff4c
"Release Date": "Jun 12 1998"Line 2 in a88ff4c vega-datasets/data/sp500-2000.csv Line 2 in a88ff4c Line 2 in a88ff4c Line 2 in a88ff4c
{"series":"Government","year":2000,"month":1,"count":430,"rate":2.1,"date":"2000-01-01T08:00:00.000Z"},vega-datasets/data/us-employment.csv Line 2 in a88ff4c vega-datasets/data/weather.csv Line 2 in a88ff4c Line 2 in a88ff4c |
|
Okay,I'll just make a release with all the changes then (when I get to it). Definitely make a datasets release before the others. Feel free to merge then. |
Closes #633
Description
This PR renames a dataset and updates references to it in this repo.
I've added an alert to document this, which will render like below:
Downstream work
The examples referenced in (#633 (comment)) will need to be updated after the major release.