fix: reduce CRLF-inflated Resource.bytes size#653
Merged
dangotbanned merged 1 commit intomainfrom Dec 21, 2024
Merged
Conversation
dangotbanned
changed the title
CRLF-inflated Resource.bytes sizeCRLF-inflated Resource.bytes size
dangotbanned
added a commit
that referenced
this pull request
Jan 25, 2025
dsmedia
added a commit
that referenced
this pull request
Feb 2, 2025
* feat: adds generation script for income.json * style: format income.py with ruff * refactor: convert lambda sort key to named function Replace lambda sort key in process_state_records with a named get_state_income_sort_key function for better readability and maintainability. This makes the sorting logic more explicit and follows Python's guidance on avoiding complex lambdas. * ci(typing): Include `income.py` for `pyright` * fix: Avoid `CRLF` on `win32` c8f3056, #653 * feat(typing): Utilize typing some more - shared `group` field is now hinted for all 4 places it is used - Including as a key function - added `Region` to indicate only `5` unique values - changed global constants `dict` -> `Mapping` to reflect they are not mutated - changed `AggregatedIncomeGroup` field to required - Otherwise it is exactly `BaseIncomeGroup` - The annotation already reflects that `BaseIncomeGroup | AggregatedIncomeGroup` * build: run `build_datapackage.py` Should have been done during #671 (`point.json`) The diff on `income.json` seems like removing a newline char? --------- Co-authored-by: dangotbanned <125183946+dangotbanned@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
crimea.json#648 (comment)crimea.json#648 (comment)Description
It turns out os.stat_result.st_size wasn't the issue.
Essentially, traces back to configuring-git-to-handle-line-endings
I forgot that I set
--global core.autocrlf true, which I'd overriden inaltairfa5fe6f(#3523)I've now forced that to
falseeverywhere I could locally, and added a.gitattributesin case this comes up with another contributor in the future