Skip to content

feat: Opt-out Error page from dark scheme color #36951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ijjk merged 8 commits into from
May 22, 2022
Merged

feat: Opt-out Error page from dark scheme color #36951

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b5b25ac
feat: Opt-out Error page from dark scheme color
icyJoseph May 16, 2022
800d642
Merge branch 'canary' into feat/opt-out-error-dark-mode
icyJoseph May 16, 2022
c8d9083
Merge branch 'canary' into feat/opt-out-error-dark-mode
icyJoseph May 17, 2022
7c27b7e
Merge branch 'canary' into feat/opt-out-error-dark-mode
icyJoseph May 17, 2022
1bf5030
Merge branch 'canary' into feat/opt-out-error-dark-mode
icyJoseph May 17, 2022
039fe22
fix: Narrow `withDarkMode` to the media-query
icyJoseph May 17, 2022
e975e69
Merge branch 'canary' into feat/opt-out-error-dark-mode
icyJoseph May 19, 2022
8b684ee
Merge branch 'canary' into feat/opt-out-error-dark-mode
ijjk May 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions packages/next/pages/_error.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const statusCodes: { [code: number]: string } = {
export type ErrorProps = {
statusCode: number
title?: string
withDarkMode?: boolean
}

function _getInitialProps({
Expand All @@ -33,7 +34,7 @@ export default class Error<P = {}> extends React.Component<P & ErrorProps> {
static origGetInitialProps = _getInitialProps

render() {
const { statusCode } = this.props
const { statusCode, withDarkMode = true } = this.props
const title =
this.props.title ||
statusCodes[statusCode] ||
Expand All @@ -49,9 +50,10 @@ export default class Error<P = {}> extends React.Component<P & ErrorProps> {
</title>
</Head>
<div>
<style
dangerouslySetInnerHTML={{
__html: `
{withDarkMode ? (
<style
dangerouslySetInnerHTML={{
__html: `
body { margin: 0; color: #000; background: #fff; }
.next-error-h1 {
border-right: 1px solid rgba(0, 0, 0, .3);
Expand All @@ -62,8 +64,11 @@ export default class Error<P = {}> extends React.Component<P & ErrorProps> {
border-right: 1px solid rgba(255, 255, 255, .3);
}
}`,
}}
/>
}}
/>
) : (
<style dangerouslySetInnerHTML={{ __html: 'body { margin: 0 }' }} />
)}
{statusCode ? (
<h1 className="next-error-h1" style={styles.h1}>
{statusCode}
Expand Down