Allow NODE_OPTIONS to container a host and port combination #59410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-davenport-fountain
requested review from
feedthejim,
huozhi,
ijjk,
shuding,
timneutkens,
wyattjoh and
ztanner
as code owners
test |
StefanMeindlDatenKraft
approved these changes
Dec 12, 2023
mark-davenport-fountain
force-pushed
the
canary
branch
from
c92a2ac to
f47865d
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This allows debugging sessions from a remote host such as a docker container. For example in package.json:
"debug": "NODE_OPTIONS='--inspect=0.0.0.0:5433' next dev",This follows the inspect options as they are specified by NodeJs - https://nodejs.org/api/cli.html#--inspecthostport
Fixes:
Why?
If you're using docker containers for development, it's impossible to attach a debugger, and this more closely follows the spec outlined by NodeJS