fix(examples): Update of with-svelte example#11952
Open
floriansalihovic wants to merge 5 commits intovercel:mainfrom
Open
fix(examples): Update of with-svelte example#11952floriansalihovic wants to merge 5 commits intovercel:mainfrom
with-svelte example#11952floriansalihovic wants to merge 5 commits intovercel:mainfrom
Conversation
- extending `ui` sample component and a rune based store - changing `moduleResolution`, `module`, and `target` to values corresponding to values emitted by svelte kit's tsconfig - consolidating dependency versions - setting engine to latest LTS: Node.js 24
floriansalihovic
requested review from
tknickman
and removed request for
a team
turbo-orchestrator
bot
added
the
area: examples
Contributor
|
@floriansalihovic is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
- replacing invalid `includes` field with `files`
- downgrading reverting changes of the engine field, requiring version 18
anthonyshew
approved these changes
Feb 27, 2026
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
anthonyshew
requested changes
Mar 2, 2026
Contributor
anthonyshew
left a comment
anthonyshew
left a comment
There was a problem hiding this comment.
I'm seeing this error when I run the lint task:
/Users/anthonyshew/projects/open/turbo/examples/with-svelte/packages/ui/dist/MyCounterButton.svelte.d.ts
1:82 error The `{}` ("empty object") type allows any non-nullish value, including literals like `0` and `""`.
- If that's what you want, disable this lint rule with an inline comment or configure the 'allowObjectTypes' rule option.
- If you want a type meaning "any object", you probably want `object` instead.
- If you want a type meaning "any value", you probably want `unknown` instead @typescript-eslint/no-empty-object-type
Author
I will have a look and fix the issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running
pnpm dlx create-turbo@latest -e with-sveltethe current version of the example creates a project with several issues.typescript-config/svelte.jsonconflicts with the configuration emitted by svelte-kit, thus the values formoduleResolution,module, andtargetare changed to the svelte-kit values.uipackage references the component in the wrong path and there were conflicts with the types.House keeping
Testing Instructions
Rum
turbo build && pnpm devin the example dir.The original build would not fail, but IDEs (i.e. Webstorm) would report errors.
webanddevdon't provide tests.