[megatron, ckpt] refactor: optimize mcore ckpt manager impl#6014
Open
ETOgaosion wants to merge 4 commits intoverl-project:mainfrom
Open
[megatron, ckpt] refactor: optimize mcore ckpt manager impl#6014ETOgaosion wants to merge 4 commits intoverl-project:mainfrom
ETOgaosion wants to merge 4 commits intoverl-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors MegatronCheckpointManager to support modular checkpointing backends, primarily introducing use_mbridge for HuggingFace format weights. The update replaces monolithic state dict generation with composable builders to avoid unnecessary overhead and includes a new suite of unit tests. Technical feedback recommends using a try...finally block to ensure transformer configuration attributes are restored after serialization and removing redundant type checks for callable objects.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactoring Megatron checkpoint menager to avoid complex logics, following the way mentioned in #5630
Problem
Now the mcore checkpoint manager has multiple backends:
mbridge, dist_checkpointing, verl original implemenation, and there are 2 model relatedsave_contentsAPIs:model, hf_model, which is complex in implemenation.Also, the API implementation in codes is complex,
save_contentsare transformed withshould_save_xxxjudgement and the backends converted touse_xxxjudgement. These naming is confusing and makes users difficult to understand saving logics.Refactor
So, let's make things clearer for mcore checkpoint mechanism.
First, refer to FSDP checkpoint APIs,
modelnow means save sharded models, andhf_modelwill save the whole model.To align with FSDP, mcore uses the same API.
For mcore, there is no sharded models, and have dist_checkpoint and mbridge backends, so in theory:
modelandhf_modelshould work the same, they all save huggingface model (only save once)modelshould use mcore dist_checkpoint implementation and hf_model should save hf_model use verl's implementation (old methods, should deprecate to reduce maintenance burden)For future and checkpoint manager refactor:
modelinsave_contentshf_modelshould only supported by mbridgeShown in Figure:
cc @ISEEKYAN @vermouth1992 @PeterSH6 @wuxibin89 @khazic @tongyx361
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,fully_async,one_step_off,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.