Skip to content

Add niketa theme#260

Merged
jschr merged 8 commits intoviatsko:masterfrom
selfrefactor:master
May 22, 2019
Merged

Add niketa theme#260
jschr merged 8 commits intoviatsko:masterfrom
selfrefactor:master

Conversation

@selfrefactor
Copy link
Contributor

@selfrefactor selfrefactor commented Apr 13, 2019

Name of the extension you are adding

Niketa theme
...

Why do you think this extension is awesome?

This collection of light themes is set in 4 groups with different background brightness. This allows usage of light theme during a bright light as well as during dark light conditions.

Also, the theme was #1 trending theme for the last 7 days at 24-04-2019 timestamp:

Trending Niketa
...

Make sure that:

  • Screenshot/GIF included (to demonstrate the plugin functionality)

  • ToC updated

@viatsko viatsko requested a review from jschr May 21, 2019 13:09
Copy link
Collaborator

@jschr jschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viatsko Looks good to me! The build appears to be failing for reasons unrelated to this PR.

@jschr
Copy link
Collaborator

jschr commented May 21, 2019

hey @selfrefactor, we'll need the build to pass before we can merge. I don't believe your changes are the reason it is failing. Maybe you need to pull the latest from this repo's master branch into your fork. Alternatively since the changes are small, you could re-fork this repo and submit another PR. Hope that works!

@selfrefactor
Copy link
Contributor Author

@jschr I just synced with your master branch but still failing. Should I proceed to re-fork and submit a new PR?

@jschr
Copy link
Collaborator

jschr commented May 22, 2019

@selfrefactor The build is failing because of some link that are now redirecting in the README. Looks like master has the same bad links (explains why updating from master didn't work).

Could you update the links in the README to the redirects according to the build output?

 1. [L0194] 301 https://marketplace.visualstudio.com/items?itemName=vicey.vscode-bond  → https://marketplace.visualstudio.com/items?itemName=yiwwan.vscode-bond 
 2. [L0769] 301 https://marketplace.visualstudio.com/items?itemName=robertohuertasm.vscode-icons  → https://marketplace.visualstudio.com/items?itemName=vscode-icons-team.vscode-icons 
 3. [L1184] 301 https://themer.mjswensen.com  → https://themer.dev 

@selfrefactor
Copy link
Contributor Author

selfrefactor commented May 22, 2019

@jschr I just did that and now it looks fine. Thank you for your help throughout the process.

@jschr jschr merged commit e3b5333 into viatsko:master May 22, 2019
@jschr
Copy link
Collaborator

jschr commented May 22, 2019

Thank you!

Copy link

@gmarcus386 gmarcus386 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants