Skip to content

feat: cancellable task #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jjmachan merged 1 commit into from
Sep 3, 2025
Merged

feat: cancellable task #2242

jjmachan merged 1 commit into from
Sep 3, 2025

Conversation

@anistark
Copy link
Member

@anistark anistark commented Sep 1, 2025

Issue Link / Problem Description

Changes Made

  • Tasks can now be cancelled
  • Executor import updated
  • added tests
  • added docs for cancellable task

Testing

How to Test

  • Automated tests added/updated
  • Manual testing steps:
    1. make test for testing all tests.
    2. uv run pytest tests/unit/test_cancellation.py to test cancelled task.

@anistark anistark requested a review from jjmachan September 1, 2025 12:52
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Sep 1, 2025
jjmachan
jjmachan approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@jjmachan jjmachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

@jjmachan jjmachan merged commit b0d25d2 into main Sep 3, 2025
10 checks passed
@jjmachan jjmachan deleted the feat/cancellable-task branch September 3, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjmachan jjmachan jjmachan approved these changes

Assignees

No one assigned

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

function generate_with_langchain_docs() and the evaluation function evaluate() do not support the caller actively stopping the task execution.

3 participants

@anistark @jjmachan