docs: fix recall formula label in SQL metrics #2405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formula on line 20 was incorrectly labeled as 'Precision' when it actually represents the Recall formula (denominator uses 'Total number of rows in reference'). Precision uses rows in response as denominator (line 16). Recall uses rows in reference as denominator (line 20). Fixes vibrantlabsai#2404
dosubot
bot
added
the
size:XS
anistark
approved these changes
Nov 6, 2025
anistark
pushed a commit
that referenced
this pull request
Nov 17, 2025
## Summary Fixes #2404 The formula for recall was incorrectly labeled as "Precision" in the SQL metrics documentation. ## Changes - Fixed line 20 in - Changed label from "Precision" to "Recall" for the formula using reference rows as denominator ## Explanation The two formulas represent different metrics: **Precision** (line 16): - Numerator: Number of matching rows - **Denominator: Total rows in response** - Measures: "Of all rows we returned, how many were correct?" **Recall** (line 20): - Numerator: Number of matching rows - **Denominator: Total rows in reference** - Measures: "Of all correct rows, how many did we return?" The formula on line 20 was mislabeled as Precision but is actually the Recall formula. ## Testing - Verified formula definitions match standard precision/recall definitions - Confirmed the fix aligns with the explanation in line 23 about F1 score being the harmonic mean of precision and recall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2404
The formula for recall was incorrectly labeled as "Precision" in the SQL metrics documentation.
Changes
Explanation
The two formulas represent different metrics:
Precision (line 16):
Recall (line 20):
The formula on line 20 was mislabeled as Precision but is actually the Recall formula.
Testing