Fix leaderboard player panel icon and compact-mode stale state#74
Merged
vicplusplus merged 1 commit intomainfrom Apr 9, 2026
Merged
Fix leaderboard player panel icon and compact-mode stale state#74vicplusplus merged 1 commit intomainfrom
vicplusplus merged 1 commit intomainfrom
Conversation
The player panel play button's icon element only set background-image, so without flex-grow / scale-to-fit it had no visible size. Made .lb-play-icon self-contained (matching .lb-refresh-icon) so it renders correctly both in row buttons (alongside .lb-row-btn__icon) and standalone in the player panel. Compact mode and short-tab-label state were cached in C# fields that persisted across OnDisable/OnEnable, but Unity recreates the visual tree on re-enable — so returning from a pushed scene (e.g. replay) left the new root in the wrong layout when the geometry-derived state matched the cache. _isCompact now reads directly from the live class list (no cache), and _usingShortLabels is reset on every BuildUI. Documented the underlying gotcha on NavigableScene.BuildUI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The player panel play button's icon element only set background-image,
so without flex-grow / scale-to-fit it had no visible size. Made
.lb-play-icon self-contained (matching .lb-refresh-icon) so it renders
correctly both in row buttons (alongside .lb-row-btn__icon) and
standalone in the player panel.
Compact mode and short-tab-label state were cached in C# fields that
persisted across OnDisable/OnEnable, but Unity recreates the visual
tree on re-enable — so returning from a pushed scene (e.g. replay)
left the new root in the wrong layout when the geometry-derived state
matched the cache. _isCompact now reads directly from the live class
list (no cache), and _usingShortLabels is reset on every BuildUI.
Documented the underlying gotcha on NavigableScene.BuildUI.