feat: YouTube preview streaming and improved search result cards#785
Open
safepay wants to merge 2 commits intovicwomg:masterfrom
Open
feat: YouTube preview streaming and improved search result cards#785safepay wants to merge 2 commits intovicwomg:masterfrom
safepay wants to merge 2 commits intovicwomg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YouTube iframe embeds fail when video owners disable embedding, corporate/school firewalls block YouTube embed domains, or privacy filters block iframes. Users can't preview videos before downloading, leading to wasted downloads and poor UX (#650).
This uses the same yt-dlp binary that already powers search and download — just an additional
-gflag to resolve a direct stream URL. If it fails, the modal closes gracefully; no existing functionality is affected.Changes:
<video>instead of iframe embed, bypassing all embed restrictions0.jpg(letterboxed) to 16:9mqdefault.jpg; replaced Bulma column grid with clean flexbox (200px fixed on desktop, full-width stacked on mobile)Fixes #650
Test plan