fix: issue where live dash streams without audio would hang#1524
Merged
mister-ben merged 3 commits intovideojs:mainfrom Aug 23, 2024
Merged
fix: issue where live dash streams without audio would hang#1524mister-ben merged 3 commits intovideojs:mainfrom
mister-ben merged 3 commits intovideojs:mainfrom
Conversation
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1524 +/- ##
==========================================
- Coverage 86.40% 86.36% -0.04%
==========================================
Files 43 43
Lines 11144 11144
Branches 2545 2545
==========================================
- Hits 9629 9625 -4
- Misses 1515 1519 +4 ☔ View full report in Codecov by Sentry. |
mister-ben
approved these changes
Aug 22, 2024
dzianis-dashkevich
approved these changes
Aug 22, 2024
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This was referenced Sep 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes this issue: #1471
Tested with this endpoint: https://livesim2.dashif.org/livesim2/segtimeline_1/WAVE/vectors/cfhd_sets/12.5_25_50/t1/2022-10-17/stream.mpd
Specific Changes proposed
Check whether media group is undefined before checking its contents
Requirements Checklist