Skip to content
This repository was archived by the owner on Jan 27, 2023. It is now read-only.

fix wrong ScaleType init error#167

Merged
vinc3m1 merged 1 commit intovinc3m1:masterfrom
peacepassion:fix_scale_type_err
Aug 3, 2016
Merged

fix wrong ScaleType init error#167
vinc3m1 merged 1 commit intovinc3m1:masterfrom
peacepassion:fix_scale_type_err

Conversation

@peacepassion
Copy link
Copy Markdown
Contributor

fix issue #166

private boolean mMutateBackground = false;
private int mResource;
private int mBackgroundResource;
private ScaleType mScaleType = ScaleType.FIT_CENTER;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If set init value for mScaleType and no android:scaleType set in xml, ImageView#init() would not call setScaleType() and in RoundedImageView constructor setScaleType would be called but super.setScaleType() cannot be called.
image

And that leads to the issue bug.

@vinc3m1 vinc3m1 merged commit cdfd169 into vinc3m1:master Aug 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants