Merged
Conversation
Owner
|
Hi @FegzDev! Thanks a lot for your PR! I'll review it as soon I find time. I checked quickly and it looks good |
Author
|
Hi @vinceglb. Have you been able to review this? |
vinceglb
approved these changes
Sep 30, 2025
Owner
vinceglb
left a comment
vinceglb
left a comment
There was a problem hiding this comment.
Thanks a lot for your PR! It is really useful! Sorry again for the delay 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added basic MIME type support across all platforms.
Some tests are not running due to the following error:
"groovy.lang.MissingPropertyException: No such property: getStartTimeMillis for class: org.gradle.api.internal.tasks.testing.results.DefaultTestResult"
I presume this is an issue with Kotlin 2.2.10.
Please review the appleMain implementation carefully. I am not very proficient with Kotlin/Native and would appreciate extra feedback there.
I intended adding an extension to MIME type map from mimetype.io as a fallback but they have a very long list.