Support for unsigned char builds#247
Closed
hirohira9119 wants to merge 1 commit intovincentlaucsb:masterfrom
Closed
Support for unsigned char builds#247hirohira9119 wants to merge 1 commit intovincentlaucsb:masterfrom
hirohira9119 wants to merge 1 commit intovincentlaucsb:masterfrom
Conversation
The current code assumes char to be signed. This commit expands the range of mappings to also support builds where char is unsigned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code assumes char to be signed, which caused issues that incorrect parsing UTF-8 in unsigned char builds. This commit adds support for unsigned char builds by expanding the range of mappings.
Fix: #222