Single Threaded + Emscripten Support#301
Merged
vincentlaucsb merged 19 commits intomasterfrom Apr 6, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
==========================================
- Coverage 90.95% 90.87% -0.08%
==========================================
Files 23 23
Lines 1515 1513 -2
Branches 617 616 -1
==========================================
- Hits 1378 1375 -3
- Misses 42 43 +1
Partials 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fix Emscripten failure
Reduce duplication
* Run emscripten tests * Very minor BasicCSVParser constructor fix * Documentation updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary: Emscripten + Single-Threading Support (v3.0.0)
Summary
This PR adds first-class support for threadless and Emscripten/WebAssembly targets while keeping the existing public API intact.
Goals
CSVReader("file.csv")ergonomics across platformsKey Changes
MmapParserwith compile-time guardsCSV_ENABLE_THREADS=0forced on EmscriptenCSV_ENABLE_THREADS=1elsewhereowned_file_streamto Emscripten onlyCMAKE_CXX_STANDARDpreprocessor dependency__cplusplusand_MSVC_LANGstreamofftosize_tconversions with checkspow10()via integral exponent enforcementsetup-emsdkby commit hashCMAKE_CROSSCOMPILING_EMULATOR=node#define CSV_ENABLE_THREADS 0)Compatibility
Validation
Reviewer Focus
CMAKE_CROSSCOMPILING_EMULATOR=node)