Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #307 +/- ##
==========================================
- Coverage 89.89% 89.86% -0.04%
==========================================
Files 25 25
Lines 1633 1657 +24
Branches 684 700 +16
==========================================
+ Hits 1468 1489 +21
Misses 45 45
- Partials 120 123 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return get_csv_head(filename, get_file_size(filename)); | ||
| } | ||
|
|
||
| CSV_INLINE size_t infer_n_cols_from_head(csv::string_view head, CSVFormat format) { |
| vector<string>({ "4", "5", "6", "" })); | ||
| } | ||
|
|
||
| TEST_CASE("Test Quoted Empty Single-Column Row", "[read_csv_empty_last_column]") { |
|
|
||
| // Verify the CSV parser can handle any arbitrary line endings composed of carriage return & newline | ||
| TEST_CASE("Cursed Newlines", "[read_csv_cursed_newline]") { | ||
| TEST_CASE("Normal Newlines", "[read_csv_normal_newline]") { |
| } | ||
|
|
||
|
|
||
| TEST_CASE("Edge-Case Newlines", "[read_csv_edge_case_newline]") { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #242. See release notes and README for deets.