Skip to content
This repository was archived by the owner on Jul 29, 2019. It is now read-only.

Conversation

@Stexxen
Copy link
Contributor

@Stexxen Stexxen commented Aug 11, 2016

Default functionality remains the same, but restriction can be lifted with a config option.
Also created Example to demonstrate new option and clusters of clusters.

Default functionality remains the same.
Also added new example
@Stexxen
Copy link
Contributor Author

Stexxen commented Aug 11, 2016

@mojoaxel thanks for merging my other pull.
This one is not a bug fix but a new feature, or rather the removal of a restriction. I've created an example, but don't think this pull entirely complies with misc/how_to_publish.md. Do you have any advice on what else I need to do?
Thanks,
S.

}
});
cluster();
cluster();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of this calls should be enough to show the new feature ;-)

@mojoaxel
Copy link
Member

mojoaxel commented Aug 11, 2016

@Stexxen Very nice! Why not!
Can you please add docs for the new option allowSingleNodeCluster here.
You just can simply commit new changes in your single_cluster branch to update this pull-request.

After that I see no reason not to merge this.

@mojoaxel
Copy link
Member

mojoaxel commented Sep 1, 2016

@Stexxen I still think the new option allowSingleNodeCluster should be documented!?

@mojoaxel mojoaxel added this to the v4.17 milestone Sep 4, 2016
Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation missing

@mojoaxel
Copy link
Member

@Stexxen Can you please add some documentation. If you can not do it please let us know so we can do it. Thanks!

@Stexxen
Copy link
Contributor Author

Stexxen commented Oct 17, 2016

apologies, I will work on this today.

@Stexxen
Copy link
Contributor Author

Stexxen commented Oct 17, 2016

@mojoaxel documentation now added, and removed a couple of the calls to cluster(). I've still left 3 in as the example is called clusterOfClusters after all ;-)

fine tuning. If undefined, default node options will be used.<br/><br/>
Default functionality only allows clustering if the cluster contains 2 or more nodes. To allow clustering of single nodes you can use the <code>allowSingleNodeCluster : true</code> property.
<pre class="prettyprint lang-js">
var clusterOptions = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should call it "options" to be coherent with the other examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Default functionality only allows clustering if the cluster contains 2 or more nodes. To allow clustering of single nodes you can use the <code>allowSingleNodeCluster : true</code> property.
<pre class="prettyprint lang-js">
var clusterOptions = {
joinCondition: function (potentialNodeOptions) {
Copy link
Member

@mojoaxel mojoaxel Oct 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "joinCondition" is from a other example and should be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"joinCondition" is not always optional. Thats why I chose to leave it in, so it is a complete example, but please confirm you want it removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be removed. It's irrelevant to the example.

@mojoaxel mojoaxel merged commit b84e9e4 into visjs:develop Oct 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants