-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Removed restriction to allow clusters of a single node. #2013
Conversation
Default functionality remains the same. Also added new example
|
@mojoaxel thanks for merging my other pull. |
| } | ||
| }); | ||
| cluster(); | ||
| cluster(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of this calls should be enough to show the new feature ;-)
|
@Stexxen I still think the new option |
mojoaxel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
documentation missing
|
@Stexxen Can you please add some documentation. If you can not do it please let us know so we can do it. Thanks! |
|
apologies, I will work on this today. |
…luster() calls in example.
|
@mojoaxel documentation now added, and removed a couple of the calls to cluster(). I've still left 3 in as the example is called clusterOfClusters after all ;-) |
docs/network/index.html
Outdated
| fine tuning. If undefined, default node options will be used.<br/><br/> | ||
| Default functionality only allows clustering if the cluster contains 2 or more nodes. To allow clustering of single nodes you can use the <code>allowSingleNodeCluster : true</code> property. | ||
| <pre class="prettyprint lang-js"> | ||
| var clusterOptions = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should call it "options" to be coherent with the other examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
docs/network/index.html
Outdated
| Default functionality only allows clustering if the cluster contains 2 or more nodes. To allow clustering of single nodes you can use the <code>allowSingleNodeCluster : true</code> property. | ||
| <pre class="prettyprint lang-js"> | ||
| var clusterOptions = { | ||
| joinCondition: function (potentialNodeOptions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "joinCondition" is from a other example and should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"joinCondition" is not always optional. Thats why I chose to leave it in, so it is a complete example, but please confirm you want it removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be removed. It's irrelevant to the example.
Default functionality remains the same, but restriction can be lifted with a config option.
Also created Example to demonstrate new option and clusters of clusters.