Skip to content
This repository was archived by the owner on Jul 29, 2019. It is now read-only.

Conversation

@wimrijnders
Copy link

@wimrijnders wimrijnders commented Oct 20, 2016

See title. This change is relevant for two reasons:

  1. For my future goal of having multiple graphs in one view. When combining graphs, the line graphs must also respect the depth order. This is for properly overlapping the graph elements of various graph types when drawing.
  2. This makes the code for the line graph more similar to the other graph types, which allows for DRY'ing the bar graph drawing code.

Wrt. 1 this is not a complete solution, but it's a first step.

Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I like the use of the new function _line.

@wimrijnders
Copy link
Author

looks good. I like the use of the new function _line.

Yes. That's the joy of DRY code.

@mojoaxel mojoaxel merged commit c92e2cd into visjs:develop Oct 20, 2016
@wimrijnders wimrijnders deleted the PR15 branch October 21, 2016 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants