This repository was archived by the owner on Jul 29, 2019. It is now read-only.
Graph3d: make setting dotSizeRatio public #2202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
While I'm at it, DRY'd the dotSize calculation. |
mojoaxel
suggested changes
Oct 21, 2016
lib/graph3d/Graph3d.js
Outdated
|
|
||
|
|
||
| Graph3d.prototype._dotSize = function() { | ||
| return this.frame.clientWidth * this.dotSizeRatio; |
Member
|
@wimrijnders Sorry for refusing to merge. I mean it more like a joke. If you want you can fix the ident, or I'll merge it as it is... |
Author
|
Crap. First time I get an actual review error. There goes my reputation.....
Nonono, you're absolutely right. You can make a joke of it but still it needs to be done right. |
mojoaxel
approved these changes
Oct 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oversight.
dotSizeRatiowasn't public in the code, but the documentation says it is.