This repository was archived by the owner on Jul 29, 2019. It is now read-only.
Support parent dir for RTL timeline and fix a small bug for editable point items #2235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojoaxel
approved these changes
Oct 27, 2016
Member
mojoaxel
left a comment
mojoaxel
left a comment
There was a problem hiding this comment.
Nice!
But I think we should also check it the <html> tag has a direction. But this could be done in a separate PR if you want.
Member
Author
|
@mojoaxel it already does it =) |
mojoaxel
reviewed
Oct 27, 2016
| this._create(container); | ||
|
|
||
| if (!options || (options && typeof options.rtl == "undefined")) { | ||
| this.options.rtl = window.getComputedStyle(this.dom.root, null).direction == "rtl"; |
Member
There was a problem hiding this comment.
This line should be better something like this:
// check if the timelines root element or one of its parents has a direction
var directionFromDom, domNode = this.dom.root;
while (!directionFromDom && domNode) {
directionFromDom = window.getComputedStyle(domNode, null).direction;
domNode = domNode.parentElement;
}
this.options.rtl = (directionFromDom && (directionFromDom.toLowerCase() == "rtl"));
Member
Author
There was a problem hiding this comment.
I'll add this to another PR? Or do you want to revert?
Member
There was a problem hiding this comment.
You could just change it and push the changes to your branch. Would be cool, if you test it before, I didn't ;-)
Member
Author
There was a problem hiding this comment.
I tested it and submitted another PR =)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now define a rtl timeline buy reading the closest parent dir. closes #2027.
and fix a small bug I caused in a previous PR which made editable point items unuseable...