Merged
Conversation
patak-cat
approved these changes
Mar 30, 2023
Member
patak-cat
left a comment
patak-cat
left a comment
There was a problem hiding this comment.
Given how small usage this has, this could be done in this major. I think it may not be a bad idea to add a message if jsxPure is defined in the config though to point people to use jsxSideEffects (at least having the message during the next major).
ArnaudBarre
force-pushed
the
drop-jsx-pure
branch
from
04acaa5 to
0819f8c
Compare
patak-cat
approved these changes
Mar 30, 2023
sapphi-red
pushed a commit
that referenced
this pull request
Mar 31, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Arnaud Barré <arnaud.barre@carbometrix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a really niche custom property that is passed down to esbuild. If you need it, set jsxSideEffects: true in the esbuild config directly.