-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Remove deprecated --disable_active_reparents flag
#17919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated --disable_active_reparents flag
#17919
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17919 +/- ##
==========================================
- Coverage 67.56% 67.55% -0.01%
==========================================
Files 1597 1597
Lines 259775 259757 -18
==========================================
- Hits 175509 175490 -19
- Misses 84266 84267 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
deepthi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need a note in the release notes summary for this?
|
Test failures are probably because tests are still using the flag. |
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Description
This PR deletes the flag deprecated in #14871.
Related Issue(s)
#17734
Checklist
Deployment Notes