-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Check consultopo loaded >=1 credentials w/-consul_auth_static_file
#18152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check consultopo loaded >=1 credentials w/-consul_auth_static_file
#18152
Conversation
Signed-off-by: Tim Vaillancourt <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
consultopo loaded >0 credentialsconsultopo loaded >=1 credentials w/-consul_auth_static_file
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18152 +/- ##
=======================================
Coverage 67.48% 67.48%
=======================================
Files 1603 1603
Lines 262337 262388 +51
=======================================
+ Hits 177034 177081 +47
- Misses 85303 85307 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
consultopo loaded >=1 credentials w/-consul_auth_static_fileconsultopo loaded >=1 credentials w/-consul_auth_static_file
GuptaManan100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Signed-off-by: Tim Vaillancourt <[email protected]>
* Check `consultopo` loaded >0 credentials Signed-off-by: Tim Vaillancourt <[email protected]> * fix test Signed-off-by: Tim Vaillancourt <[email protected]> * fix test, again Signed-off-by: Tim Vaillancourt <[email protected]> * force CI to run again Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]>
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
Signed-off-by: Tim Vaillancourt <[email protected]>
Description
This PR confirms
consultopoloaded >= 1 credential(s) when using-consul_auth_static_fileThis is to address no validation errors when a valid-but-empty JSON config is provided, ie:
{}Related Issue(s)
Related to: #18150
Checklist
Deployment Notes