Skip to content

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Oct 28, 2025

Description

This is a backport of #18824

@vitess-bot vitess-bot bot added Backport This is a backport Component: Build/CI Merge Conflict Skip CI Skip CI actions from running Type: CI/Build labels Oct 28, 2025
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Oct 28, 2025

Hello @arthurschreiber, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 18826 -R vitessio/vitess
git reset --hard origin/release-22.0
git cherry-pick -m 1 ef11221e00fd00cc9fcdf337cba6bb5b96e6e340

@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Oct 28, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v22.0.2 milestone Oct 28, 2025
@arthurschreiber arthurschreiber force-pushed the backport-18824-to-release-22.0 branch from 69fde08 to 14ba18d Compare October 29, 2025 10:29
@arthurschreiber arthurschreiber removed Skip CI Skip CI actions from running Merge Conflict labels Oct 29, 2025
Signed-off-by: Arthur Schreiber <[email protected]>
@arthurschreiber arthurschreiber force-pushed the backport-18824-to-release-22.0 branch from 14ba18d to 4889a1e Compare October 29, 2025 10:33
@arthurschreiber arthurschreiber marked this pull request as ready for review October 29, 2025 10:35
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.73%. Comparing base (b0287cf) to head (4889a1e).
⚠️ Report is 11 commits behind head on release-22.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-22.0   #18826      +/-   ##
================================================
+ Coverage         67.53%   69.73%   +2.19%     
================================================
  Files              1600     1601       +1     
  Lines            262116   213198   -48918     
================================================
- Hits             177023   148667   -28356     
+ Misses            85093    64531   -20562     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arthurschreiber arthurschreiber merged commit 612cc79 into release-22.0 Oct 29, 2025
107 of 108 checks passed
@arthurschreiber arthurschreiber deleted the backport-18824-to-release-22.0 branch October 29, 2025 12:14
tanjinx pushed a commit to slackhq/vitess that referenced this pull request Nov 13, 2025
Signed-off-by: Arthur Schreiber <[email protected]>
Co-authored-by: Arthur Schreiber <[email protected]>
Signed-off-by: Tanjin Xu <[email protected]>
tanjinx pushed a commit to slackhq/vitess that referenced this pull request Nov 13, 2025
Signed-off-by: Arthur Schreiber <[email protected]>
Co-authored-by: Arthur Schreiber <[email protected]>
Signed-off-by: Tanjin Xu <[email protected]>
tanjinx added a commit to slackhq/vitess that referenced this pull request Nov 13, 2025
* [release-22.0] ci: use the newest mysql apt config package (vitessio#18790) (vitessio#18793)

Signed-off-by: Arthur Schreiber <[email protected]>
Co-authored-by: Arthur Schreiber <[email protected]>
Co-authored-by: Arthur Schreiber <[email protected]>
Signed-off-by: Tanjin Xu <[email protected]>

* [release-22.0] [CI] Use the draft state from the event payload instead of calling `curl`. (vitessio#18650) (vitessio#18652)

Signed-off-by: Arthur Schreiber <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Tanjin Xu <[email protected]>

* [release-22.0] ci: extract os tuning (vitessio#18824) (vitessio#18826)

Signed-off-by: Arthur Schreiber <[email protected]>
Co-authored-by: Arthur Schreiber <[email protected]>
Signed-off-by: Tanjin Xu <[email protected]>

* [release-22.0] ci: extract os tuning (vitessio#18824) (vitessio#18826)

Signed-off-by: Arthur Schreiber <[email protected]>
Co-authored-by: Arthur Schreiber <[email protected]>
Signed-off-by: Tanjin Xu <[email protected]>

* [release-22.0] ci: DRY up MySQL Setup (vitessio#18815) (vitessio#18836)

Signed-off-by: Arthur Schreiber <[email protected]>
Co-authored-by: Arthur Schreiber <[email protected]>
Signed-off-by: Tanjin Xu <[email protected]>

* fix typo

Signed-off-by: Tanjin Xu <[email protected]>

* delete mysql57 tests

Signed-off-by: Tanjin Xu <[email protected]>

* setup secrets

Signed-off-by: Tanjin Xu <[email protected]>

* fix tests

Signed-off-by: Tanjin Xu <[email protected]>

* fix typo

Signed-off-by: Tanjin Xu <[email protected]>

* rm java docker test

Signed-off-by: Tanjin Xu <[email protected]>

---------

Signed-off-by: Arthur Schreiber <[email protected]>
Signed-off-by: Tanjin Xu <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Arthur Schreiber <[email protected]>
Co-authored-by: Arthur Schreiber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants