Skip to content

Conversation

@vitess-bot
Copy link
Contributor

This Pull Request bumps the Golang version to go1.24.11 and the bootstrap version to 43.6.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

  • Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests.
  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.

cc @vitessio/release

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@vitess-bot vitess-bot added Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go labels Dec 3, 2025
@vitess-bot vitess-bot requested a review from frouioui as a code owner December 3, 2025 00:35
@vitess-bot vitess-bot added Skip CI Skip CI actions from running Type: CI/Build labels Dec 3, 2025
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 3, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work labels Dec 3, 2025
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 3, 2025

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

@vitess-bot vitess-bot bot added NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 3, 2025
@vitess-bot vitess-bot requested a review from a team December 3, 2025 00:35
@github-actions github-actions bot added this to the v22.0.3 milestone Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.72%. Comparing base (2bb2897) to head (9b5c70b).
⚠️ Report is 2 commits behind head on release-22.0.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-22.0   #18976   +/-   ##
=============================================
  Coverage         69.72%   69.72%           
=============================================
  Files              1601     1601           
  Lines            213265   213270    +5     
=============================================
+ Hits             148691   148710   +19     
+ Misses            64574    64560   -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says Skip CI Skip CI actions from running Type: CI/Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants