fix: treat vitest and vi the same#851
Merged
veritem merged 1 commit intovitest-dev:mainfrom Dec 26, 2025
Merged
Conversation
G-Rath
force-pushed
the
treat-vi-and-vitest-the-same
branch
from
61e1da6 to
f2104a4
Compare
Contributor
Author
Member
|
@G-Rath I agree. From type exports, vi and vitest are indeed the same. https://github.com/vitest-dev/vitest/blob/7b10ab4cd7d23d3c520fd1f6956ce99108f70a04/packages/vitest/globals.d.ts#L12C3-L12C44 |
veritem
reviewed
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My understanding is that
vitestis a re-export ofvimaking it exactly the same so I don't think it makes sense to mark it as a different type of vitest function call - I'm guessing it was done like this forconsistent-vitest-vibut that can be handled easily by checking the head node.The only rule I know for sure that this impacts is
unbound-method, but there might be a few others