-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(jsdom): override globals that Fetch API relies on #8390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jsdom): override globals that Fetch API relies on #8390
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The error originates from Vitest when used with jsdom. See vitest-dev/vitest#7906 for more details. This issue is fixed in vitest-dev/vitest#8390, but not yet released.
|
Sorry to bump this @sheremet-va. Is there any way we could get this added into the next release? Seems like it's currently slotted for the v4 release. Not sure the timeline on when v4 will be released, so this may not be important enough. |
You can use Vitest 4 beta to test this. |
|
pnpm patch for anyone that might want to manually apply this change to
|
Description
Fixes #8374
Fixes #7906
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.