Skip to content

feat: add hooks with type-safe extra context to TestAPI#8623

Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom
ysfaran:feat/type-safe-hooks
Oct 3, 2025
Merged

feat: add hooks with type-safe extra context to TestAPI#8623
sheremet-va merged 1 commit intovitest-dev:mainfrom
ysfaran:feat/type-safe-hooks

Conversation

@ysfaran
Copy link
Contributor

@ysfaran ysfaran commented Sep 26, 2025

Description

This PR adds hooks to the TestAPI (test), that provide type-safe ExtraContext.

Details can be viewed here: #8617.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it. -> Not sure how I could achieve this here, as it would be a type error.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Tests fail on my branch, but the same tests also fail on the main branch. So it doesn't seem to be related to this PR changes.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Sep 26, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e9d1502
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68d6494930f42e000839c155
😎 Deploy Preview https://deploy-preview-8623--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va merged commit 6b21cfe into vitest-dev:main Oct 3, 2025
11 of 14 checks passed
@ysfaran ysfaran deleted the feat/type-safe-hooks branch October 6, 2025 08:16
@djohnson-aperture
Copy link

Sorry to bring up a dead thread, but is there any chance that beforeAll/afterAll would be supported. As mentioned, this is available in Playwright already. I understand that currently all fixtures are in the same bucket type-wise, so it makes sense from a typescript stance that they're not available in the *all hooks, in the off chance that someone tries to use a test-scoped context. Just curious if it's already in the roadmap, considering that this PR was reviewed and merged

@sheremet-va
Copy link
Member

Sorry to bring up a dead thread, but is there any chance that beforeAll/afterAll would be supported. As mentioned, this is available in Playwright already. I understand that currently all fixtures are in the same bucket type-wise, so it makes sense from a typescript stance that they're not available in the *all hooks, in the off chance that someone tries to use a test-scoped context. Just curious if it's already in the roadmap, considering that this PR was reviewed and merged

#9553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants