Skip to content

builtin: remove useless test for array#27027

Open
lcheylus wants to merge 1 commit intovlang:masterfrom
lcheylus:test-array
Open

builtin: remove useless test for array#27027
lcheylus wants to merge 1 commit intovlang:masterfrom
lcheylus:test-array

Conversation

@lcheylus
Copy link
Copy Markdown
Contributor

The suppressed test had a wrong format with redundant parentheses: test test_fixed_array_literal_eq in vlib/builtin/array_test.v

  • Before this fix:
$ ./v test vlib/builtin/array_test.v
---- Testing... ----------------------------------------------------------------------------------------------------------------------------
vlib/builtin/array_test.v:948:9: notice: redundant parentheses are used
  946 |     // vfmt off
  947 |     assert ([1, 2, 3]!) == [1, 2, 3]!
  948 |     assert (([1, 2, 3]!)) == [1, 2, 3]!
      |            ~~~~~~~~~~~~~~
  949 |     // vfmt on
  950 | }
 OK       3.003 ms vlib/builtin/array_test.v
--------------------------------------------------------------------------------------------------------------------------------------------
Summary for all V _test.v files: 1 passed, 1 total. Elapsed time: 582 ms, on 1 job. Comptime: 576 ms. Runtime: 3 ms.
  • After this fix:
$ ./v test vlib/builtin/array_test.v
---- Testing... ----------------------------------------------------------------------------------------------------------------------------
 OK       3.551 ms vlib/builtin/array_test.v
--------------------------------------------------------------------------------------------------------------------------------------------
Summary for all V _test.v files: 1 passed, 1 total. Elapsed time: 568 ms, on 1 job. Comptime: 561 ms. Runtime: 3 ms.

The suppressed test had a wrong format with redundant parentheses.

Signed-off-by: Laurent Cheylus <foxy@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant