[Hardware] Add processor inputs to platform validation#16680
[Hardware] Add processor inputs to platform validation#16680njhill merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
NickLucche
left a comment
There was a problem hiding this comment.
LGTM, benchmark is running fine on TPU.
…16680) Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
…16680) Signed-off-by: Joe Runde <Joseph.Runde@ibm.com> Signed-off-by: Yang Wang <elainewy@meta.com>
…16680) Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
…16680) Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
…16680) Signed-off-by: Joe Runde <Joseph.Runde@ibm.com> Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
…16680) Signed-off-by: Joe Runde <Joseph.Runde@ibm.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
A followup to #16291
This moves the
current_platform.validate_requestcall to after input preprocessing happens, so that theProcessorInputscan also be passed to the platform. This will ensure the platform plugins have access to the tokenized prompt and multimodal data for validation as well.This is a slightly api breaking change since implementations that don't accept the
processed_inputskwarg would break, but I've updated the tpu implementation here and vllm-ascend hasn't implemented it yet.I'll wait for @NickLucche to test this on TPU this time before merging to make sure I didn't break it again