Skip to content

[Bugfix] Consistent ascii handling in tool parsers#18883

Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom
chaunceyjiang:ensure_ascii
May 30, 2025
Merged

[Bugfix] Consistent ascii handling in tool parsers#18883
DarkLight1337 merged 1 commit intovllm-project:mainfrom
chaunceyjiang:ensure_ascii

Conversation

@chaunceyjiang
Copy link
Copy Markdown
Collaborator

@chaunceyjiang chaunceyjiang commented May 29, 2025 •
edited by github-actions Bot
Loading

FIX #18881

Follow #17704

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify Bot added the frontend label May 29, 2025
@chaunceyjiang
[Bugfix] Consistent ascii handling in tool parsers
594bc44 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
Copy link
Copy Markdown
Collaborator Author

chaunceyjiang commented May 29, 2025

/cc @DarkLight1337 PTAL.

@DarkLight1337 DarkLight1337 requested a review from aarnphm May 29, 2025 10:51
DarkLight1337
DarkLight1337 approved these changes May 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 30, 2025 02:13
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 30, 2025
@DarkLight1337 DarkLight1337 merged commit 77164da into vllm-project:main May 30, 2025
67 of 69 checks passed
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@chaunceyjiang @amitm02
[Bugfix] Consistent ascii handling in tool parsers (vllm-project#18883)
5a48ce3 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: amit <amit.man@gmail.com>
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@chaunceyjiang @amitm02
[Bugfix] Consistent ascii handling in tool parsers (vllm-project#18883)
6be98e3 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: amit <amit.man@gmail.com>
@chaunceyjiang chaunceyjiang mentioned this pull request Jun 3, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aarnphm aarnphm aarnphm approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Tools results encoding in ascii when using "required" tool call with server.

3 participants

@chaunceyjiang @aarnphm @DarkLight1337