[Bugfix] use float32 precision in samplers/test_logprobs.py for comparing with HF #6409
[Bugfix] use float32 precision in samplers/test_logprobs.py for comparing with HF #6409mgoin merged 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
|
👋 Hi! Thank you for contributing to the vLLM project. Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well. To run full CI, you can do one of these:
🚀 |
|
/ready |
|
CI failure looks real - I can reproduce locally on an L4 GPU Haven't seen that before... |
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Head branch was pushed to by a user without write access
|
I was able to solve the error by halving the number of blocks in the prefix prefill kernel when |
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
|
@simon-mo auto-merge got disabled on this one, but now it is good. |
…ring with HF (vllm-project#6409) Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
…ring with HF (vllm-project#6409) Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: Alvant <alvasian@yandex.ru>
…ring with HF (vllm-project#6409) Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
Fixes #6408
This PR changes the precision in
tests/samplers/test_logprobs.pyfromhalftofloat.This is needed because the test is comparing the actual values of the logprobs against the equivalent outputs from HF. There is precedent established for doing this in other tests (see e.g., here or here).
This change ensures that the test does not fail on an H100 GPU.