[CI/Build] vLLM cache directory for images#6444
[CI/Build] vLLM cache directory for images#6444simon-mo merged 8 commits intovllm-project:mainfrom DarkLight1337:image-assets
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well. To run full CI, you can do one of these:
🚀 |
|
@WoosukKwon do you think we can move the XLA cache under |
|
|
||
| def get_cache_dir(): | ||
| """Get the path to the cache for storing downloaded assets.""" | ||
| path = Path(VLLM_ASSETS_CACHE) |
There was a problem hiding this comment.
need to expanduser here?
There was a problem hiding this comment.
It is already done in vllm.env so no need to do it again here.
xwjiang2010
left a comment
There was a problem hiding this comment.
just a small comment.
@DarkLight1337 Yes. I think that's good for consistency. |
|
BTW, we also have config-related cache under |
The only cache I found under that directory is |
|
LGTM |
Signed-off-by: Alvant <alvasian@yandex.ru>
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
This PR adds a cache directory for vLLM. Similar to HuggingFace, the location of the cache is given by the environment variable
VLLM_CACHE_ROOT, or$XDG_CACHE_HOME/vllmif it is not provided (e.g.~/.cache/vllmby default). Under this directory, we have two subdirectories for containing different types of data:VLLM_XLA_CACHE_PATHfor XLA persistent cache directory. cc @WoosukKwonVLLM_ASSETS_CACHEfor downloaded assets.s3orcurlto download the images used in VLM examples and tests. cc @xwjiang2010Accordingly,
VLLM_CONFIG_ROOThas been updated to take thevllmdirectory into account. This means that:$XDG_CONFIG_HOMEto$XDG_CONFIG_HOME/vllm.VLLM_CONFIG_ROOTshould no longer prependvllm/since that is included in the environment variable already.