Pass environment variables to compile phase of a Java function container

[dheerajjoshim]

Is this a BUG REPORT or FEATURE REQUEST?:
FEATURE REQUEST

What happened:
Passing environment variable using --env command line argument doesn't propagate these variable to compile phase. This is essentially required to pass command line arguments to mvn command.

What you expected to happen:
Environment variable passed using --env command line argument must be available or injected to compile phase of Java function

How to reproduce it (as minimally and precisely as possible):
Pass environment variable --env FOO=BAR to a Java function and edit the function deployment file and check compile phase. environment variable FOO=BAR is not passed

Anything else we need to know?:
No

Environment:

• Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.3", GitCommit:"2bba0127d85d5a46ab4b778548be28623b32d0b0", GitTreeState:"clean", BuildDate:"2018-05-21T09:17:39Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.3", GitCommit:"2bba0127d85d5a46ab4b778548be28623b32d0b0", GitTreeState:"clean", BuildDate:"2018-05-21T09:05:37Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

• Kubeless version (use kubeless version):
  Kubeless version: v1.0.0

• Cloud provider or physical cluster:
  Using kubernetes on docker edge channel for windows.

[dheerajjoshim]

Can a PR be submitted for this?

[andresmgot]

Yes @dheerajjoshim, were you thinking on working on this? Note that the code for runtimes have been moved to https://github.com/kubeless/runtimes

[dheerajjoshim]

@andresmgot Yes we are considering kubeless seriously for deployment and this issue is blocking us to use Java functions behind proxy and we need to consider other serverless technologies. So i was hoping i can submit a PR and it can come in next release.

Is there a page explaining how to set up local code base for development environment?

[andresmgot]

You can take a look to:

https://kubeless.io/docs/dev-guide/ and
https://github.com/kubeless/runtimes/blob/master/DEVELOPER_GUIDE.md

Let me know if you have any question

[dheerajjoshim]

I did follow these instructions. Unfortunately I am using Windows machine and make bootstrap command actually fails in cygwin. For my PR i had to borrow a Linux machine to get it to work.
So it's kind of hard to get this working on Windows. I am not sure if any one tried to deploy it in Windows

[andresmgot]

Yes, unfortunately I have never tried in windows. Maybe you can try to manually install the tools that are specified in the bootstrap task?

[dheerajjoshim]

This is merged with #1030