consider resources for initContainers if provided in function deploym…#1074
consider resources for initContainers if provided in function deploym…#1074andresmgot merged 7 commits intovmware-archive:masterfrom abinet:master
Conversation
|
I think there is a general problem with CI build right now. From other POV vetting is already included into So that's why I'm going to remove ./script/validate-vet from the validation step. |
andresmgot
left a comment
There was a problem hiding this comment.
Thank you for the PR! It's looking good so far :)
Regarding the issue with vet, I agree, I had to disable it for other projects as well so I am okay removing it.
I have a minor comment but apart from that, do you mind adding an example in the docs of how to use this? Maybe this section is the most appropriate for that: https://github.com/kubeless/kubeless/blob/master/docs/advanced-function-deployment.md#custom-deployment
|
Thank you for the changes! |
Issue Ref: #960
Description:
This PR allows to provide default resources for initContainers if they need to be created.