Skip to content
This repository was archived by the owner on Dec 15, 2021. It is now read-only.

Merge deployment containers as well#1114

Merged
andresmgot merged 3 commits intovmware-archive:masterfrom
d0x2f:master
Feb 17, 2020
Merged

Merge deployment containers as well#1114
andresmgot merged 3 commits intovmware-archive:masterfrom
d0x2f:master

Conversation

@d0x2f
Copy link
Contributor

@d0x2f d0x2f commented Feb 17, 2020

Issue Ref: #1113 @andresmgot

Description:

Merge container values when merging the deployment template config to allow specifying things like resources, labels, annotations, etc for containers.

TODOs:

  • Ready to review
  • Automated Tests
  • Docs

I just added a resource value in the documented example to suggest to readers that this is possible. Let me know if I should explicitly mention it somewhere.

Dylan McGannon and others added 3 commits February 17, 2020 18:49
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@andresmgot andresmgot merged commit ac91c1e into vmware-archive:master Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants