This repository was archived by the owner on Dec 15, 2021. It is now read-only.
If HPA already exists, perform an update.#1117
Merged
andresmgot merged 1 commit intovmware-archive:masterfrom Mar 2, 2020
d0x2f:master
Merged
If HPA already exists, perform an update.#1117andresmgot merged 1 commit intovmware-archive:masterfrom d0x2f:master
andresmgot merged 1 commit intovmware-archive:masterfrom
d0x2f:master
Conversation
andresmgot
approved these changes
Mar 2, 2020
Contributor
andresmgot
left a comment
andresmgot
left a comment
There was a problem hiding this comment.
Thanks for the fix @d0x2f and the test!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Ref: #1116
Description:
If the creation of a HPA returns an error becasue one with that name already exists, then perform an update.
This prevents the error triggering a retry up to the retry limit and slowing down queue consumption.
TODOs: