This repository was archived by the owner on Dec 15, 2021. It is now read-only.
Remove description for CRDs#887
Merged
andresmgot merged 3 commits intovmware-archive:masterfrom Aug 17, 2018
Merged
Conversation
added 2 commits
August 17, 2018 11:00
arapulido
reviewed
Aug 17, 2018
Contributor
arapulido
left a comment
arapulido
left a comment
There was a problem hiding this comment.
The kafka-zookeeper.jsonnet also defines a CRD with description
Contributor
|
@andresmgot it seems that description is not removed, but has been moved to a new field CustomResourceColumnDefinition. We should improve this later on |
Contributor
Author
|
Good catch. Thanks @arapulido. Honestly the description we are setting doesn't give any useful information. |
arapulido
approved these changes
Aug 17, 2018
Contributor
arapulido
left a comment
arapulido
left a comment
There was a problem hiding this comment.
lgtm. We should improve the CRDs definitions once 1.12 gets released
andresmgot
pushed a commit
that referenced
this pull request
Aug 17, 2018
* adding readme * Support setting env variable for bearer token * Revert "adding readme" This reverts commit 6ed2ef2. * formatting * Delete glide.yaml Now Gopkg.toml is used instead * Remove description for CRDs (#887) * Remove description for CRDs * Update docs * Adapt kafka manifest * Renaming GetOverriddenClientConfig to GetInClusterConfig, removing redundant error handler for getting config * adding readme * Support setting env variable for bearer token * Revert "adding readme" This reverts commit 6ed2ef2. * formatting * Renaming GetOverriddenClientConfig to GetInClusterConfig, removing redundant error handler for getting config * Adding docs for KUBELESS_TOKEN_FILE_PATH * Fix format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Ref: Fixes #881
Description:
In K8s 1.11 the
Descriptionfield is not available.TODOs: