Skip to content
This repository was archived by the owner on Dec 15, 2021. It is now read-only.

Allow underscore in runtimes. Remove flaky test #951

Merged
andresmgot merged 1 commit into from
Nov 7, 2018
Merged

Allow underscore in runtimes. Remove flaky test #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/langruntime/langruntime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func (l *Langruntimes) getVersionFromRuntime(runtime string) string {

// GetRuntimeInfo returns all the info regarding a runtime
func (l *Langruntimes) GetRuntimeInfo(runtime string) (RuntimeInfo, error) {
runtimeID := regexp.MustCompile("^[a-zA-Z]+").FindString(runtime)
runtimeID := regexp.MustCompile("^[a-zA-Z_-]+").FindString(runtime)
for _, runtimeInf := range l.AvailableRuntimes {
if runtimeInf.ID == runtimeID {
return runtimeInf, nil
Expand Down
1 change: 0 additions & 1 deletion tests/integration-tests-cronjob.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ load ../script/libtest
verify_cronjob_trigger get-python '*/60 * * * *' '"GET / HTTP/1.1" 200 11 "" "curl/7.56.1"'
delete_cronjob_trigger get-python
verify_clean_object cronjobtrigger get-python
verify_clean_object cronjob get-python
}

@test "Test no-errors" {
Expand Down