This repository was archived by the owner on Dec 15, 2021. It is now read-only.
Fixes evaluation of the file suffix for functions with base64 content type#987
Merged
andresmgot merged 2 commits intovmware-archive:masterfrom Jan 24, 2019
Merged
Fixes evaluation of the file suffix for functions with base64 content type#987andresmgot merged 2 commits intovmware-archive:masterfrom
andresmgot merged 2 commits intovmware-archive:masterfrom
Conversation
andresmgot
approved these changes
Jan 24, 2019
Contributor
andresmgot
left a comment
andresmgot
left a comment
There was a problem hiding this comment.
Thanks for the patch @me-viper! I am curious, what's your use case for this? Why sending the content of the function as base64 if it's not a binary?
Contributor
Author
|
Nothing exciting really. We are extending our system to support kubeless. For historical reasons our implementation is passing functions around in base64 so it made sense to use out of box base64 support rather than do additional conversions. |
Contributor
|
Understood. Let me merge this. Until the next release is available you can use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Ref: Fixes #986
Description:
Fixes getFileName function to infer file suffix for base64 encoded functions.
TODOs:
- [ ] Docs